ci: Use more accurate test coverage. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #134 +/- ##
============================================
+ Coverage 52.86% 63.86% +11.00%
============================================
Files 35 80 +45
Lines 3757 7328 +3571
============================================
+ Hits 1986 4680 +2694
- Misses 1541 2163 +622
- Partials 230 485 +255
|
jsimnz
approved these changes
Jan 27, 2022
| # This only covers how much of the package is tested by itself (unit test). | ||
| .PHONY: test\:coverage-quick | ||
| test\:coverage-quick: | ||
| go test ./... -race -coverprofile=coverage-quick.txt -covermode=atomic |
There was a problem hiding this comment.
Did you guys make a descision regarding the -race flag on the coverage-quick make command?
There was a problem hiding this comment.
So this coverage-quick rule isn't ran on any CI steps, just there for local coverage report generation of only unit tests (so no integration / cross package coverage).
We did decide to go with -race flag for the benefits. I checked locally the running time difference is like just a few seconds.
I can include the -race flag in the PR and then merge.
Closed
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
In addition to better coverage also add the `-race` flag to our checks to detect races.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more accurate test coverage which makes our tests 63.5% covered as it now also accounts for integration tests.